Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conformance to style standards #767

Merged
merged 7 commits into from
Oct 22, 2018
Merged

Add conformance to style standards #767

merged 7 commits into from
Oct 22, 2018

Conversation

tony-ho
Copy link
Contributor

@tony-ho tony-ho commented Oct 4, 2018

Fixes

Fixes #766

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Update ESLint rules as follows:

  • exclude global-require errors (245 occurrences)
  • set complexity and max-statements to warn

Fix remaining ESLint errors.
Add npm run script for ESDoc.
Add TravisCI scripts for ESLint and ESDoc.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 4, 2018
@SendGridDX
Copy link
Collaborator

SendGridDX commented Oct 4, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tony-ho tony-ho mentioned this pull request Oct 6, 2018
Closed
reedsa
reedsa reviewed Oct 10, 2018
View reviewed changes
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are good changes, thank you! Would love an additional commit to take care of the comment I've added. I am happy to approve once that's in!

reedsa
reedsa reviewed Oct 10, 2018
View reviewed changes
package.json Show resolved Hide resolved
@reedsa reedsa added status: waiting for feedback waiting for feedback from the submitter and removed status: code review request requesting a community code review or review from Twilio labels Oct 10, 2018
@devchas devchas added hacktoberfest difficulty: medium fix is medium in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Oct 11, 2018
@reedsa reedsa added status: ready for deploy code ready to be released in next deploy and removed status: waiting for feedback waiting for feedback from the submitter labels Oct 11, 2018
@thinkingserious thinkingserious merged commit 7026ae5 into sendgrid:master Oct 22, 2018
@tony-ho tony-ho deleted the style-conformance branch October 23, 2018 00:40
@tony-ho tony-ho mentioned this pull request Oct 27, 2018
Merged
6 tasks
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Feb 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 19, 2020
Merged
This was referenced Apr 17, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelalmeidatk rafaelalmeidatk rafaelalmeidatk requested changes

@reedsa reedsa reedsa approved these changes

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Require conformance to style standards
6 participants
@tony-ho @SendGridDX @reedsa @rafaelalmeidatk @thinkingserious @devchas