Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contact-importer] Update to support @sendgrid/client v6.X #770

Merged
merged 2 commits into from
Oct 22, 2018

Conversation

aslafy-z
Copy link
Contributor

@aslafy-z aslafy-z commented Oct 5, 2018

Closes #427

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Upgrade contact-importer to use @sendgrid/client v6.X

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 5, 2018
@aslafy-z aslafy-z changed the title Update contact-importer to support v6 [contact-importer] Update to support @sendgrid/client v6.X Oct 5, 2018
@aslafy-z
Copy link
Contributor Author

aslafy-z commented Oct 5, 2018

Still need to upgrade Bottleneck to v2. https://github.com/SGrondin/bottleneck#upgrading-to-v2

@devchas devchas added hacktoberfest difficulty: medium fix is medium in difficulty type: community enhancement feature request not on Twilio's roadmap labels Oct 11, 2018
@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter status: hacktoberfest approved and removed status: code review request requesting a community code review or review from Twilio labels Oct 11, 2018
@thinkingserious
Copy link
Contributor

Hello @aslafy-z,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @aslafy-z,

Is this still WIP?

Thanks!

With Best Regards,

Elmer

@aslafy-z
Copy link
Contributor Author

aslafy-z commented Oct 12, 2018

Bottleneck can be upgraded in another PR. It's not WIP anymore @thinkingserious.

Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update contact-importer to support v6.X
4 participants