-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding an IpManagement helper #236
Conversation
@thinkingserious for the assist? |
We did not get a chance to reply to your question on this Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt. Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!) You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is failing to pass CI because the new helper's implementation isn't being included in the lib/sendgrid-ruby.rb
file. Please add a new line to lib/sendgrid-ruby.rb
pointing to lib/sendgrid/helpers/ip_management/ip_management.rb
, and push a commit to this branch with the new change.
@@ -1,5 +1,6 @@ | |||
require_relative 'sendgrid/client' | |||
require_relative 'sendgrid/version' | |||
require_relative 'sendgrid/helpers/ip_management/ip_management' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clee Added ip_management here, re: #236 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I'm seeing Travis checking it now.
@brokenthumbs Have you signed the CLA?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have signed the CLA, but the status is still pending, looks like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, one of my commits doesn't have my GitHub email associated with it. Hm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the approach here for dealing with an old commit, that does not have an email address associated with the commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, that seems to be the issue. The easiest solution would be for you to use git rebase --interactive
, mark the commit that has the wrong email for 'edit' instead of 'pick', and then use git commit --amend --reset-author
on that commit. (If you need more help to understand all of that, no problem, I'm on Freenode and OFTC as clee. Hit me up there!)
@clee Managed to sign the CLA :) Thanks for the pointers. |
Rebased from upstream 🤞 |
Thanks @brokenthumbs! |
Thanks for walking me through the code 👍 |
Looks like the tests are still failing though 😕 |
No worries about the failing tests @brokenthumbs. They are not related to your PR. I'll get those fixed separately. Thanks! |
Hello @brokenthumbs, |
I mostly followed the helper for Settings, and think that this is what #214 was asking for?
ToDo:
.ips.get
in the spec.I've never used SendGrid, but figured this would be a good opportunity to learn how to grok a random repository during Hacktober. Thanks for organizing!