fix: Replaced FaviconWebpackPlugin to WebappWebpackPlugin #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update webpack-addons to @webpack-cli/webpack-scaffold
sendilkumarn
requested changes
Jul 21, 2018
generator.js
Outdated
| @@ -136,8 +136,8 @@ module.exports = class WebpackGenerator extends Generator { | |||
| .then(answer => { | |||
| if (answer) { | |||
| favPath = answer['favPath']; | |||
| this.options.env.configuration.dev.topScope.push('const FaviconsWebpackPlugin = require("favicons-webpack-plugin");'); | |||
| this.dependencies.push("favicons-webpack-plugin"); | |||
| this.options.env.configuration.dev.topScope.push("const WebappWebpackPlugin = require('webapp-webpack-plugin');"); | |||
There was a problem hiding this comment.
Can you please revert the quotes here ?
There was a problem hiding this comment.
Sure, In next commit
|
@sendilkumarn can you create a basic scaffold to check whether this fix actually solves the problem or not? |
|
@sendilkumarn I have cross checked it and I think it's ready to merge. |
dhruvdutt
approved these changes
Jul 25, 2018
rishabh3112
added a commit
to rishabh3112/webpack-scaffold-pwa
that referenced
this pull request
Jul 25, 2018
This was referenced Jul 25, 2018
|
I am on it 👍 I will merge this today 😊 |
sendilkumarn
approved these changes
Jul 27, 2018
|
It will certainly cause a conflict with #24 @sendilkumarn. I have integrated #22 into #24. |
|
Closing this in favor of #24 |
sendilkumarn
pushed a commit
that referenced
this pull request
Jul 27, 2018
* fix: Replaced FaviconWebpackPlugin to WebappWebpackPlugin * bugfix(favicon): Revert quotes * bugfix(favicon): Removed unnecessory manifest.json file * feat(swReference): Add html-webpack-plugin and Update Tests * feat(seReference): [Feature Working] Add template for index.js * feat(swReference): Add support for custom entry * feat(swReference): Change copy destination of manifest.json to root * bugfix: fixed some minor issues * feat: All fix and merge in this branch Closes #22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11
Requires a check @sendilkumarn