feat(swReference): Reference SW in application #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update webpack-addons to @webpack-cli/webpack-scaffold
feat: Add theme color validation
|
Have a look @dhruvdutt @sendilkumarn , |
rishabh3112
changed the title
|
@rishabh3112 awesome 🎉 |
|
@sendilkumarn I found some bugs while testing like:
If you have a look at my 2nd commit can you suggest that the approch with I am proceeding is correct in terms of maintainability or not. |
|
@rishabh3112 Nice job. 💯 You can go ahead and fix the bugs you've identified. The fix for these looks like something which is out of scope of this PR. You can add a new PR preferably and then rebase this one. |
Bugfix/relative paths
|
@dhruvdutt can you check this up |
|
Need not merge #22 Now |
|
Any feedback on this PR @sendilkumarn @dhruvdutt ?? |
dhruvdutt
reviewed
Jul 27, 2018
This was referenced Jul 27, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers #5
@dhruvdutt @sendilkumarn needs guide to proceed further