commit v2.3.2

* date: November 27, 2023 * last security fix introduced problem where spaces in Title where no longer replaced by hyphens, this version brings back those hyphens ([issue 23](#23) thanks for pointing it out @nhimthaoan)
senlin · Nov 27, 2023 · 1ffa191 · 1ffa191
1 parent 486eb6c
commit 1ffa191
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -2,7 +2,7 @@
 
 [![plugin version](https://img.shields.io/wordpress/plugin/v/so-pinyin-slugs.svg)](https://wordpress.org/plugins/so-pinyin-slugs) [![WP compatibility](https://plugintests.com/plugins/so-pinyin-slugs/wp-badge.svg)](https://plugintests.com/plugins/so-pinyin-slugs/latest) [![PHP compatibility](https://plugintests.com/plugins/so-pinyin-slugs/php-badge.svg)](https://plugintests.com/plugins/so-pinyin-slugs/latest)
 
-###### Last updated on November 23, 2023
+###### Last updated on November 27, 2023
 ###### tested up to WP 6.4
 ###### Authors: [Pieter Bos](https://github.com/senlin)
 ###### [Stable Version](https://wordpress.org/plugins/so-pinyin-slugs) (via WordPress Plugins Repository)
@@ -75,6 +75,11 @@ This repo is open to _any_ kind of contributions.
 
 ## Changelog
 
+### 2.3.2
+
+* date: November 27, 2023
+* last security fix introduced problem where spaces in Title where no longer replaced by hyphens, this version brings back those hyphens ([issue 23](https://github.com/senlin/pinyin-slugs/issues/23) thanks for pointing it out @nhimthaoan)
+
 ### 2.3.1
 
 * date: November 23, 2023

diff --git a/inc/functions.php b/inc/functions.php
@@ -6,7 +6,7 @@
   * and return the slug in Pinyin when true
   *
   * since version 2.0.0
-  * @modified 2.3.1
+  * @modified 2.3.2
   */
 
 function getPinyinSlug( $strTitle ) {
@@ -58,10 +58,13 @@ function getPinyinSlug( $strTitle ) {
 		$strRet = $origStrTitle;
 	}
 
-	// Validate the output
+	// Replace spaces with hyphens
+	$strRet = str_replace(' ', '-', $strRet);
+
+	// Sanitize the slug: allow only alphanumeric, hyphens, and underscores
 	$strRet = preg_replace('/[^A-Za-z0-9-_]/', '', $strRet);
 
 	// Return the sanitized slug
 	return $strRet;
-}
 
+}
diff --git a/readme.txt b/readme.txt
@@ -3,7 +3,7 @@ Contributors: senlin
 Tags: pinyin, permalinks, slugs, Mandarin, Chinese, traditional, simplified
 Requires at least: 4.4
 Tested up to: 6.4
-Stable tag: 2.3.1
+Stable tag: 2.3.2
 License: GPLv2 or later
 License URI: http://www.gnu.org/licenses/gpl-2.0.html
 
@@ -79,6 +79,11 @@ Please open an issue over at [Github](https://github.com/senlin/so-pinyin-slugs/
 
 == Changelog ==
 
+= 2.3.2 =
+
+* date: November 27, 2023
+* last security fix introduced problem where spaces in Title where no longer replaced by hyphens, this version brings back those hyphens ([issue 23](https://github.com/senlin/pinyin-slugs/issues/23) thanks for pointing it out @nhimthaoan)
+
 = 2.3.1 =
 
 * date: November 23, 2023

diff --git a/so-pinyin-slugs.php b/so-pinyin-slugs.php
@@ -4,7 +4,7 @@
 Plugin URI: https://so-wp.com/plugin/pinyin-slugs
 Description: Transforms Simplified or Traditional Chinese character titles into Pinyin to create a permalink friendly slug.
 Author: SO WP
-Version: 2.3.1
+Version: 2.3.2
 Author URI: https://so-wp.com
 Text Domain: so-pinyin-slugs
 */
@@ -84,7 +84,7 @@ function init() {
 	function constants() {
 
 		/* Set the version number of the plugin. */
-		define( 'SOPS_VERSION', '2.3.1' );
+		define( 'SOPS_VERSION', '2.3.2' );
 
 		/* Set constant path to the plugin directory. */
 		define( 'SOPS_DIR', trailingslashit( plugin_dir_path( __FILE__ ) ) );