Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace spaces with dashes #23

Closed
nhimthaoan opened this issue Nov 25, 2023 · 6 comments
Closed

Replace spaces with dashes #23

nhimthaoan opened this issue Nov 25, 2023 · 6 comments

Comments

@nhimthaoan
Copy link

Hello, in version 2.3.1 the plugin removed spaces instead of converting them to dashes.
This makes the slug ugly, can you return it to the way it was before, replace the spaces with dashes.

loremipsumdolorsitamet
lorem-ipsum-dolor-sit-amet
@senlin
Copy link
Owner

senlin commented Nov 27, 2023

Hello,
Thanks for reporting the issue.
You're right, this indeed creeped in.
Today I will release a fix that brings back those hyphens and once I have done that I will update this thread.
Apologies for the inconvenience.

@nhimthaoan
Copy link
Author

There is one more problem: old urls that contain Chinese characters will have a 404 page not found error.

@senlin
Copy link
Owner

senlin commented Nov 27, 2023

I'm not sure I understand? With the plugin installed characters are changed to Pinyin, so how can an old URL contain Chinese characters?

@senlin
Copy link
Owner

senlin commented Nov 27, 2023

Also I am unable to replicate that

@senlin
Copy link
Owner

senlin commented Nov 27, 2023

see this screencast to show that Chinese characters in URLs remain and there are no 404's.

senlin added a commit that referenced this issue Nov 27, 2023
@senlin
commit v2.3.2
1ffa191 
* date: November 27, 2023
* last security fix introduced problem where spaces in Title where no longer replaced by hyphens, this version brings back those hyphens ([issue 23](#23) thanks for pointing it out @nhimthaoan)
@senlin
Copy link
Owner

senlin commented Nov 27, 2023

released v2.3.2 that fixes the reported issue, closing this thread

(the 404 issue is not related and must have a different source)

@senlin senlin closed this as completed Nov 27, 2023
@senlin senlin mentioned this issue Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@senlin @nhimthaoan