-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
14 add forced alignment #69
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release_051 #69 +/- ##
===============================================
+ Coverage 63.04% 63.93% +0.88%
===============================================
Files 63 67 +4
Lines 2073 2465 +392
===============================================
+ Hits 1307 1576 +269
- Misses 766 889 +123 ☔ View full report in Codecov by Sentry. |
hey @ibevers , i have changed the base of the pull request to release_040 (I am doing so with all urgent PRs) so that once this is ready we will merge it to the feature branch first and then to main |
@fabiocat93 Got it--that makes sense! |
To-dos:
|
Hi @ibevers , what conflict do you see? I have tried installing the package with |
|
Oh, this is because of an issue with poetry and packages ending with a number. Can you try following the instructions in the CONTRIBUTING.md? I suspect this will solve your issue |
@fabiocat93 Ah, I see--fixed! Thanks! |
d27ace7
to
896a68f
Compare
@fabiocat93 I think this is mergable now |
model (torch.nn.Module): The alignment model. | ||
waveform_segment (torch.Tensor): The audio segment to be processed. | ||
lengths (Optional[torch.Tensor]): Lengths of the audio segments. | ||
model_type (str): The type of the model ('torchaudio' or 'huggingface'). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use the data structures we have HFModel and TorchModel?
@ibevers I have removed the conflicts with the release_051 branch and left some comments. in general, try to use the data structures we created to handle models, devices, ... |
@fabiocat93 thank you for the review! I will work on updates tomorrow |
@fabiocat93 why did you delete release_051? |
@ibevers Oh I was trying to keep the repo cleaner and deleted some branches that have already been merged. I didn't notice that you were trying to merge into release_051. Sorry for that. Can you please open a pull request to main once you are ready to merge? |
@fabiocat93 no problem, will do! |
No description provided.