Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS 10.12.6 gowitness v1.0.2 incorrectly identifying Google Chrome version? #3

Closed
heyitsols opened this issue Feb 5, 2018 · 4 comments

Comments

@heyitsols
Copy link

heyitsols commented Feb 5, 2018

It looks like gowitness on macOS 10.12.6 (16G1212) thinks my installed version of Google Chrome is 58.0.3029.110, even when using the path option to point it to version 64.0.3282.140

~ % gowitness single https://google.com --chrome-path="/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome"
FATA[2018-02-05 10:44:23] Chrome version is older than v60              chromeversion=58.0.3029.110

~ % /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --version
Google Chrome 64.0.3282.140

Even stops me from running commands like version

~ % gowitness version
FATA[2018-02-05 10:46:38] Chrome version is older than v60              chromeversion=58.0.3029.110
@heyitsols heyitsols changed the title gowitness v1.0.2 incorrectly identifying Google Chrome version? macOS 10.12.6 gowitness v1.0.2 incorrectly identifying Google Chrome version? Feb 5, 2018
@leonjza
Copy link
Member

leonjza commented Feb 5, 2018

Thanks for the report! Could you show me the output of the single run with --log-level=debug added? For example"

$ gowitness --log-level=debug single --url https://google.com
DEBU[2018-02-05 15:04:32] Chrome path not set or invalid. Performing search
DEBU[2018-02-05 15:04:32] Google Chrome path                            chrome-path="/Applications/Google Chrome.app/Contents/MacOS/Google Chrome"
DEBU[2018-02-05 15:04:32] Chrome version                                version=64.0.3282.140
DEBU[2018-02-05 15:04:32] Screenshot path                               screenshot-path=/Users/user1
DEBU[2018-02-05 15:04:32] Opening buntdb                                database-location=gowitness.db
DEBU[2018-02-05 15:04:32] Processing URL                                url="https://google.com"
INFO[2018-02-05 15:04:33] Response code                                 status="200 OK" url="https://google.com"
INFO[2018-02-05 15:04:33] Final URL after redirects                     final-url="https://www.google.co.za/?gfe_rd=cr&dcr=0&ei=agr" url="https://google.com"

@heyitsols
Copy link
Author

Aha, that showed the problem!

~ % gowitness --log-level=debug single --url https://google.com
DEBU[2018-02-05 14:49:01] Chrome path not set or invalid. Performing search
DEBU[2018-02-05 14:49:01] Google Chrome path                            chrome-path="/Applications/Google Chrome.app/Contents/MacOS/Google Chrome"
DEBU[2018-02-05 14:49:01] Google Chrome path                            chrome-path=/Applications/Chromium.app/Contents/MacOS/Chromium
FATA[2018-02-05 14:49:02] Chrome version is older than v60              chromeversion=58.0.3029.110

~ % /Applications/Chromium.app/Contents/MacOS/Chromium --version
Chromium 58.0.3029.110

However, it might be good to check the versions of all results of the search and use any suitable one.

User error is the reason my in-line override wasn't working, I had it wrapped in " but also was escaping spaces with \

Thanks for getting back to me so quickly!

@leonjza
Copy link
Member

leonjza commented Feb 5, 2018

No problem! Something I can definitely improve on so will keep this one open so I don't forget about it.

leonjza added a commit that referenced this issue Feb 6, 2018
Should improve the experience reported in #3
@leonjza
Copy link
Member

leonjza commented Feb 28, 2018

I tagged an improvement for this in v1.0.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants