build_new_apk: carry extra files from META-INF over #283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some features such as Kotlin coroutines use files stored in the
META-INF
directory. As described in the Apktool documentationThis results in
patchapk
producing APKs that crash as soon as Kotlin coroutines (or anything else that depend on files stored there) are used:This patch examines whether the
META-INF
directory contains anything else except the standard files used forjarsigner
type (old) APK signatures (*.RSA
,*.SF
andMANIFEST.MF
). If so, it uses the built-in ZIP file support of the Python standard library to append such files. For ZIP paths,/
is used as a separator regardless of the password, while for everything else, I usedos.path.join
andos.sep
.Edit: clarified that
/
is only used for ZIP paths