allow 'sqlite connect' to download temp files #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Thanks for this. I'm spread a bit thin at the moment but will definitely give this a test soon. |
|
Sorry for the time this took and thank you for contributing! 🙌 |
leonjza
reviewed
Feb 17, 2021
| if use_wal: | ||
| upload([local_path + '-wal', full_remote_file + '-wal']) | ||
| if use_jnl: | ||
| upload([local_path + '-journal', full_remote_file + '-journal']) | ||
| else: | ||
| click.secho('NOT synchronizing changes back to device. Use --sync if you want that.', fg='green') | ||
|
|
||
| # maak skoon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
sqlite connectdoes download the database file only (without temp files for "Shared Memory" and "Write-Ahead-Log") not all DB data is visible for inspection.A test has been done TikTok for Android, where a database is accessed with
sqlite connectbefore and after applying the patch from this PR. See this summary for reference:https://github.com/mame82/objection/blob/android_sqlite_shm/sqlite_patch.md
I have not done tests to re-upload those temporary files after the database was altered (
--syncoption), thus the respective code is disabled. It could be enabled by settingwrite_back_tmp_sqlitetoTruehere