(fix) keychain dumper misses entries with kSecAttrSynchronizable=true #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ynchronizable=true
…SecAttrSynchronizable=true
|
Thank you! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a practical test with an iOS app on iOS 14.4 I discovered that the keychain dumper does not dump all keychain entries.
In detail all keychain entries were missing that had been created using the option
query[kSecAttrSynchronizable]=kCFBooleanTrue.This behavior can be changed by adding
query[kSecAttrSynchronizable]=kSecAttrSynchronizableAnyto the keychain query. The present pull requests contains these changes so the keychain dumper can return all entries no matter ifkSecAttrSynchronizablehas been set to true or false (the latter is the default value).Tested on iOS 14.4
Edit: The function for deleting all keychain entries was also ignoring entries with query[kSecAttrSynchronizable]=kCFBooleanTrue
. I have added a commit that changes theempty()` method to also delete such entries.