Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Keep packages sorted in composer.json #116

Merged
merged 1 commit into from Nov 23, 2018
Merged

Enhancement: Keep packages sorted in composer.json #116

merged 1 commit into from Nov 23, 2018

Conversation

localheinz
Copy link
Contributor

This PR

  • keeps packages sorted in composer.json

@DonCallisto
Copy link
Contributor

LGTM but we should improve this with some automated tool like php-cs or something like this.
Of course is not strictly related to this PR but we should consider it.

@localheinz
Copy link
Contributor Author

@DonCallisto

Perhaps https://github.com/localheinz/composer-normalize?

@DonCallisto
Copy link
Contributor

Yes!

@jakzal jakzal merged commit 492881f into sensiolabs:master Nov 23, 2018
@jakzal
Copy link
Member

jakzal commented Nov 23, 2018

Thank you! 🍺

@localheinz localheinz deleted the feature/sort-packages branch November 23, 2018 13:39
@localheinz
Copy link
Contributor Author

Thank you, @DonCallisto and @jakzal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@localheinz @DonCallisto @jakzal