This repository has been archived by the owner on Feb 24, 2023. It is now read-only.
Deprecate routing annotation of FrameworkExtraBundle in favor of Symfony Core #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
force-pushed
the
deprecate-routing-annotations
branch
2 times, most recently
from
2a31619
to
417fb40
Compare
Tobion
force-pushed
the
deprecate-routing-annotations
branch
from
417fb40
to
444683c
Compare
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Feb 24, 2018
…favor of Symfony Core (Tobion) This PR was merged into the 5.1.x-dev branch. Discussion ---------- Deprecate routing annotation of FrameworkExtraBundle in favor of Symfony Core Since symfony/symfony#23044 routing annotation is part of Symfony Core. The only extra features that the routing annotation from SensioFrameworkExtraBundle has are - service config for `@Route` which we don't need anymore - Either you use class-named services, then you don't need the "service" property at all. - Or you don't use class-named services. In this case the better solution to me, is for people to create a alias in the container from the controller class to to service id instead of specifying the service id in the routing. Then you're set as well and that is already common practice with autowiring. - `@Method` does not provide real value as people agree in symfony/symfony#25103 This resolves symfony/symfony#25103 Commits ------- 444683c Deprecate routing annotation of FrameworkExtraBundle in favor of Symfony Core
stof
reviewed
Feb 26, 2018
|
|
||
| /** | ||
| * @Route(service="test.invokable_class_level.predefined") |
There was a problem hiding this comment.
wasn't this meant to test the routing loader of this bundle ? Testing the Symfony one does not make sense here.
There was a problem hiding this comment.
I would assume no, as this test is part of the TemplateAnnotationTest.
There was a problem hiding this comment.
I think I originally created these tests to prevent regressions for the @Template annotation. I simply registered them as service this way, so my best guess is that this can be removed.
Tobion
added a commit
to Tobion/symfony-docs
that referenced
this pull request
Jun 30, 2018
The routing annotations of SensioFrameworkExtraBundle are deprecate since sensiolabs/SensioFrameworkExtraBundle#562 Also the example code in this documentation does not use SensioFrameworkExtraBundle at all but the core annotation as it should be. So installing the SensioFrameworkExtraBundle is pointless.
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jul 24, 2018
…on, javiereguiluz) This PR was merged into the 4.0 branch. Discussion ---------- [Routing] do not install SensioFrameworkExtraBundle The routing annotations of SensioFrameworkExtraBundle are deprecate since sensiolabs/SensioFrameworkExtraBundle#562 Also the example code in this documentation does not use SensioFrameworkExtraBundle at all but the core annotation as it should be. So installing the SensioFrameworkExtraBundle is pointless. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- c98babf Reword 6119b67 [Routing] do not install SensioFrameworkExtraBundle
Guikingone
pushed a commit
to Guikingone/symfony-docs
that referenced
this pull request
Feb 12, 2019
The routing annotations of SensioFrameworkExtraBundle are deprecate since sensiolabs/SensioFrameworkExtraBundle#562 Also the example code in this documentation does not use SensioFrameworkExtraBundle at all but the core annotation as it should be. So installing the SensioFrameworkExtraBundle is pointless.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since symfony/symfony#23044 routing annotation is part of Symfony Core.
The only extra features that the routing annotation from SensioFrameworkExtraBundle has are
@Routewhich we don't need anymore@Methoddoes not provide real value as people agree in Annotation routing in the core symfony/symfony#25103This resolves symfony/symfony#25103