-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Routing page suggest installing SensioFrameworkExtraBundle while Doctrine Annotations suffices #10426
Comments
You are right about this. However, the There's an open issue (symfony/symfony#25361) to move ALL annotations into Symfony core. If we do that, then we'll update the docs as you say, because there will be no need install this bundle. That's why I'm closing this issue for now as "won't fix" ... but we appreciate that you created it and we thank you for helping us improve the docs. Thanks! |
OK, but to avoid confusion, isn't it better to replace the That would have saved me time and would not have caused confusion. I see that this is already proposed in #9742, but that PR doesn't seem to be merged? |
We did it like this because "composer require annotations" is something easy to understand ... but "composer require sensio/framework-extra-bundle" is not that easy ("sensio": who or what is that?, "extra bundle": extra what? where are my annotations? etc.) |
For me it was harder to understand than easier. Nowhere on the page it is stated that
|
@javiereguiluz as RFC on the subjet will probably take some time can I open a PR to address this issue? |
The first instruction on the Routing page (
routing.rst
) is to install theannotations
Composer package, which turns out to be an alias forsensio/framework-extra-bundle
.However, in several places (see also sensiolabs/SensioFrameworkExtraBundle#562 and sensiolabs/SensioFrameworkExtraBundle#585) it is mentioned that routing via annotations is part of Symfony core since version 3.4, and that the SensioFrameworkExtraBundle is not needed anymore.
However, when I don't require the Composer package/alias, I get the following error:
After trying several things and almost giving up, I discovered that installing the
doctrine/annotations
Composer package did the trick.I think it's better to change the documentation of the routing page such that
doctrine/annotations
is mentioned instead ofannotations
.The text was updated successfully, but these errors were encountered: