This repository has been archived by the owner on Feb 24, 2023. It is now read-only.
Update the docs about Route and Method annotations #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Sep 3, 2018
|
|
||
| .. code-block:: yaml | ||
| The ``@Method`` annotation from SensioFrameworkExtraBundle has been removed. | ||
| Instead, the Symfony ``@Route`` annotation defines a new ``methods`` option to |
There was a problem hiding this comment.
The methods option was introduced in Symfony 2.2. So I would not call it "new" here.
There was a problem hiding this comment.
see symfony/symfony#6738 for the PR adding it in Symfony
xabbuh
reviewed
Sep 3, 2018
|
|
||
| The ``@Route`` annotation maps a route pattern with a controller:: | ||
| The Symfony annotation has the same options as the SensioFrameworkExtraBundle |
There was a problem hiding this comment.
The service option is not part of the core @Route annotation. Maybe it's worth to mention here that you should use FQCN as service ids now.
xabbuh
added a commit
to xabbuh/SensioFrameworkExtraBundle
that referenced
this pull request
Sep 7, 2018
That section was removed in PR sensiolabs#585.
fabpot
added a commit
that referenced
this pull request
Sep 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still confusing for some users (see symfony/symfony-docs#10142) so I propose to stop explaining the deprecated annotations and just explain how to upgrade.