This repository has been archived by the owner on Feb 24, 2023. It is now read-only.
Make Template guesser look at parent classes for bundle #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… form of proxying going on
| @@ -57,7 +57,25 @@ public function guessTemplateName($controller, Request $request, $engine = 'twig | |||
There was a problem hiding this comment.
please don't change file permissions. If you are on windows, you can use git config core.filemode false to configure git not to change them.
fabpot
added a commit
that referenced
this pull request
Mar 18, 2012
Commits ------- 804f63f Use single variable for reflection class instance 7a0c7c0 Make Template guesser look at parent classes for bundle Discussion ---------- Make Template guesser look at parent classes for bundle (The better way) Solves the same issue as this pull request: #98 but is a better way to do that - inside getBundleForClass() method and without catching exceptions (which must be slower and would be the default behavior for all secured via annotations controllers with the latest JMSSecurityExtraBundle) --------------------------------------------------------------------------- by olegstepura at 2012-03-08T22:28:31Z Fixes https://github.com/symfony/symfony-standard/issues/285 after applying symfony/symfony-standard#275
|
see #104 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on some code that generates proxy classes for my controllers and got stuck so I installed the CG library for some reference and have just came to realize that the FrameworkExtraBundle was now broken.
Now it look at the class_parents of the $bundleName to see if maybe one of the parents is in the bundle, if so, break out and keep going or throw the ex as was expected