This repository has been archived by the owner on Jan 6, 2020. It is now read-only.
Simplify the initial code of generated bundles #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Jul 17, 2015
…, javiereguiluz) This PR was merged into the 3.0.x-dev branch. Discussion ---------- Simplify the initial code of generated bundles In the past, generated bundles were a good opportunity to show Symfony features (such as the routing parameters). Nowadays we have the pre-generated AppBundle and the Symfony Demo application, so we can make the generated bundles as clean as possible. Commits ------- ee56e4c Fixed some failing tests 9df0487 Simplify the initial code of generated bundles 0dad775 Changing route /hello/{name} to /
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, generated bundles were a good opportunity to show Symfony features (such as the routing parameters). Nowadays we have the pre-generated AppBundle and the Symfony Demo application, so we can make the generated bundles as clean as possible.