Fixes non-termination on zero width attribute. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this would greedily hang on the text "[,]" because as text-property-not-all was assumed incorrectly to always return greater than point if it returned at all. In this case, we just advance to end. Closes sensorflo#8 Closes sensorflo#9
|
Thank you for your help. I did chose a slightly different solution (see commit e6b8e69) which fits better my mind, but you directed me directly to the point where I had to make the fix. I hope my solution doesn't miss some cases which your solution doesn't. Due to the tests I added I am quite confident. |
tarsius
pushed a commit
to emacsmirror/adoc-mode
that referenced
this pull request
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this would greedily hang on the text "[,]" because
as text-property-not-all was assumed incorrectly to always return
greater than point if it returned at all. In this case, we just
advance to end.
Closes #8
Closes #9