This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Next arrow fixes #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 8, 2016 13:21
… in next period. This happens when the max date is in the bottom "row" of the calendar in day/week view.
| else if @period() == 'year' | ||
| @firstYearOfDecade(currentDate).add(10, 'year') | ||
|
|
||
| {'arrow-hidden': !@currentDate.isWithinBoundaries(nextPeriodDate)} |
There was a problem hiding this comment.
I think this can be simplified significantly. Year, Quarter & Month work fine as is. So we can just default to the old implementation in those cases:
date = @firstDate().clone().add(cols * rows, @period())for day & week, however, we should be looking at the beginning of the month rather than whatever .add(cols * rows, @period() gives us.
So, I think something like this should work:
nextArrowCss: ->
[cols, rows] = @period.dimentions()
date = @firstDate().clone().add(cols * rows, @period())
date = date.startOf('month') if @period() in ['day', 'week']
{'arrow-hidden': !@currentDate.isWithinBoundaries(date)}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: If the max date is within the bottom two "rows" of the calendar (in day/week view) & inside the next month then the next month arrow is hidden.
The dates are still selectable, but are greyed out which is pretty confusing. This change will show the next arrow when at least 1 date is valid in the next month.