Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for percentile stats from cloudwatch metrics #329

Conversation

rajiv-g
Copy link
Contributor

@rajiv-g rajiv-g commented Mar 25, 2019

Pull Request Checklist

Is this in reference to an existing issue?
#328

General

  • Update Changelog following the conventions laid out here

  • Update README with any necessary configuration snippets

  • Binstubs are created if needed

  • RuboCop passes

  • Existing tests pass

New Plugins

  • Tests

  • Add the plugin to the README

  • Does it have a complete header as outlined here

Purpose

Known Compatibility Issues

@majormoses
Copy link
Member

Thanks for your contribution to Sensu plugins! Without people like you submitting PRs we couldn't run the project. I will review it shortly.

Copy link
Member

@majormoses majormoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@majormoses
Copy link
Member

I merged master and fixed some conflicts, once CI passes I will merge and work on a release.

@majormoses majormoses merged commit c351d2d into sensu-plugins:master Apr 3, 2019
@majormoses
Copy link
Member

released: https://rubygems.org/gems/sensu-plugins-aws/versions/17.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants