Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use append when managing group on Windows #537

Merged
merged 1 commit into from
Mar 9, 2017
Merged

Use append when managing group on Windows #537

merged 1 commit into from
Mar 9, 2017

Conversation

cwjohnston
Copy link
Contributor

Description

This change updates the group resource defined in the _windows recipe to set the value of the append property to true.

Motivation and Context

Per #531, the group resource needs append set to true in order to be used successfully with the built-in "Administrator" group.

Closes #531

How Has This Been Tested?

Existing integration tests pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

[windows] set append to true on group resource
3ca38e0 
Per sensu#531, the `group`
resource declared in _windows needs `append true` set in order to be
used successfully with the built-in "Administrator" group.

Closes sensu#531
@cwjohnston cwjohnston added this to the 4.0 milestone Feb 15, 2017
@amdprophet amdprophet merged commit 9ffe2dc into sensu:develop Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amdprophet amdprophet amdprophet approved these changes

@agoddard agoddard Awaiting requested review from agoddard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Unable to use the built-in Administrators group with windows-client
2 participants
@cwjohnston @amdprophet