Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sensu_check] fix conditional validation of subscribers/standalone #547

Merged
merged 2 commits into from
Mar 14, 2017

Conversation

cwjohnston
Copy link
Contributor

@cwjohnston cwjohnston commented Mar 14, 2017

Description

Fix bug introduced by #538.

Motivation and Context

#538 introduces a change which broke the build but somehow passed CI.

How Has This Been Tested?

Fixes existing broken test.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

Copy link
Contributor

@gcymbalski gcymbalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm, according to Chef, looks like actions can be either arrays /or/ strings and it's up to resources to make it happen- a la https://github.com/vkhatri/chef-filebeat/pull/59/files

@cwjohnston
Copy link
Contributor Author

@gcymbalski thanks for pointing that out. How does it look now?

@gcymbalski
Copy link
Contributor

Perfect!

@cwjohnston cwjohnston merged commit 753b174 into sensu:develop Mar 14, 2017
@cwjohnston cwjohnston deleted the hotfix/check-validation branch March 14, 2017 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants