Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #430 #490

Closed
wants to merge 2 commits into from
Closed

Fixes #430 #490

wants to merge 2 commits into from

Conversation

asachs01
Copy link
Contributor

Description

Adds logrotate note per 430

Motivation and Context

Solves #430

How Has This Been Tested?

yarn server

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New doc/guide
  • Fixing errata
  • Update (Add missing or refresh existing content)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • All tests have passed.

@asachs01 asachs01 requested a review from a team as a code owner June 13, 2018 17:42
@sinthetix sinthetix added the in progress Currently being worked label Jun 13, 2018
@afstanton afstanton added ready for review PR is ready to review and removed in progress Currently being worked labels Jun 13, 2018
@asachs01
Copy link
Contributor Author

Fuuuu, search and replace did a number. Redoing this.

@asachs01 asachs01 closed this Jun 13, 2018
@asachs01 asachs01 deleted the core/fix/add-logrotate-aix branch June 13, 2018 17:45
@afstanton afstanton removed the ready for review PR is ready to review label Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwjohnston cwjohnston Awaiting requested review from cwjohnston

@Blue0ctober Blue0ctober Awaiting requested review from Blue0ctober

@apaskulin apaskulin Awaiting requested review from apaskulin

@rgeniesse rgeniesse Awaiting requested review from rgeniesse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asachs01 @afstanton @sinthetix