Adding danger class #888
Closed
Adding danger class #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this use case is covered by the existing WARNING callout style. In general, DANGER callouts are reserved for issues of harm to people or property. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a style for any note prefixed with
DANGER. This is in relation to #887 . Rather than removing the content entirely, since this is a feature of the software, this will instead call attention to the fact that using RMQ as the transport is our recommended best practice.Review Instructions
Add a note with
_DANGER: THIS IS A DANGER MESSAGE_to content. This should show up like: