Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for subscriptions #12

Merged
merged 1 commit into from Apr 12, 2018

Conversation

testeddoughnut
Copy link
Contributor

This adds support for setting a subscription/check pair as a check
dependency.

I don't do much work in ruby, please be gentle =).

Signed-off-by: M. David Bennett mdavidbennett@syntheticworks.com

This adds support for setting a subscription/check pair as a check
dependency.

I don't do much work in ruby, please be gentle =).

Signed-off-by: M. David Bennett <mdavidbennett@syntheticworks.com>
@cwjohnston
Copy link
Contributor

@testeddoughnut thanks for the pull request! I think what you are doing here makes sense, but we do have concerns about potential performance impact when the API returns a large number of events.

Given that the implementation here requires operators to opt-in using the subscription: prefix, I think we can merge this as-is and document our performance concern as a caveat.

cc @portertech for 👍 / 👎

@majormoses
Copy link

bump

@jaredledvina
Copy link

Double bumping on this as my team would really love to be able to depend on a subscription check pair. I would be very interested if we had any rough figures on the perf impact (or when to avoid doing this).

@portertech
Copy link
Contributor

portertech commented Apr 12, 2018

As this feature is opt-in (not hitting /events unless a dependency includes "subscription:") I'm a 👍

Merging with the intention of making a few minor changes (to the Ruby not the functionality).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants