Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow subscription/check pairs in check dependencies filter #713

Merged
merged 3 commits into from
Sep 5, 2018

Conversation

apaskulin
Copy link
Contributor

Description

Sensu Core 1.5 includes support for specifying a subscription/check pair in the check dependencies filter.

Motivation and Context

Closes #707

Review Instructions

  • Does the db-notes subscription example make sense?
  • For the performance warning, is there any way to provide rough figures or guidance on when you might want to avoid using this?

@apaskulin apaskulin added this to the Sensu Core 1.5 milestone Sep 4, 2018
@Blue0ctober Blue0ctober added the in progress Currently being worked label Sep 4, 2018
{{< /highlight >}}

_WARNING: Specifying a subscription/check pair in the check dependencies filter
may impact Sensu's performance in large-scale installations._
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to be more specific here? Ideally by providing rough figures or guidance on when you might want to avoid using this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per sensu/sensu-extensions-check-dependencies#12 I think this starts to be a concern in cases where thousands of entries are being returned by the /events API endpoint.

I've opened sensu/sensu-extensions-check-dependencies#13 as a feature request that may help mitigate the performance impact in such cases.

@@ -406,12 +406,31 @@ Here's an example of a check definition that will be filtered if a check named `
}
{{< /highlight >}}

Or, define a dependency by specifying the subscription and the check.
Here's an example of a check definition that will be filtered if any check named `mysql` on any client subscribed to the `db-nodes` subscription is already alerting:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads a little oddly to me. How about this?

Here's an example of a check definition that will be filtered if a check named mysql is already alerting on any client subscribed to the db-nodes subscription:

Copy link
Contributor

@cwjohnston cwjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a slight tweak

@apaskulin apaskulin merged commit c0290e4 into master Sep 5, 2018
@apaskulin apaskulin deleted the filter-update branch September 5, 2018 17:45
@Blue0ctober Blue0ctober removed the in progress Currently being worked label Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update check dependencies filter to support subscriptions
3 participants