Add ansible-lint run to sanity tests

This is the second static analysis tool that Ansible Galaxy runs on
the code when we import our collection. Which means that we should be
running it too.

Makefile

@@ -38,6 +38,7 @@ requirements:  ## Install development requirements
 .PHONY: sanity
 sanity:  ## Run sanity tests
 	flake8
+	ansible-lint -p roles/*
 	ansible-test sanity --python $(python_version)
 
 .PHONY: units

roles/backend/tasks/main.yml

@@ -71,10 +71,11 @@
   tags: [run_backend]
 
 - name: Check for sensu-backend init command
-  shell:
+  command:
     cmd: sensu-backend init -h
   register: init_command_test
   failed_when: false  # Never fail, we just want to know if init exists.
+  changed_when: false  # Displaying help is read-only operation.
 
 - name: Initialize backend
   command:

roles/install/tasks/apt/install.yml

@@ -1,8 +1,11 @@
 ---
+# Why did we kill the 403 (package installs should not use latest) check?
+# Because we really do want to be able to upgrade the packages to the latest
+# stable version.
 - name: Install latest component version
   apt:
     name: "{{ item }}"
-    state: latest
+    state: latest  # noqa 403
   when: version == "latest"
   loop: "{{ components }}"
 

roles/install/tasks/yum/install.yml

@@ -1,8 +1,11 @@
 ---
+# Why did we kill the 403 (package installs should not use latest) check?
+# Because we really do want to be able to upgrade the packages to the latest
+# stable version.
 - name: Install latest component version
   yum:
     name: "{{ item }}"
-    state: latest
+    state: latest  # noqa 403
   when: version == "latest"
   loop: "{{ components }}"
 

sanity.requirements

@@ -1,3 +1,4 @@
+ansible-lint
 flake8
 pycodestyle
 pylint