Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use package liveness in keepalived #2601

Merged
merged 8 commits into from
Jan 21, 2019
Merged

Use package liveness in keepalived #2601

merged 8 commits into from
Jan 21, 2019

Conversation

echlebek
Copy link
Contributor

@echlebek echlebek commented Jan 11, 2019

What is this change?

This commit makes use of package liveness in keepalived, in order
to achieve durable keepalives. With this change applied, failing
keepalives will continue firing even if one or more backends is
lost. (Assuming etcd quorum is intact)

Why is this change necessary?

Closes #2530
Closes #2622

Does your change need a Changelog entry?

Yes

This commit makes use of package liveness in keepalived, in order
to achieve durable keepalives. With this change applied, failing
keepalives will continue firing even if one or more backends is
lost. (Assuming etcd quorum is intact)

Signed-off-by: Eric Chlebek <eric@sensu.io>
Signed-off-by: Eric Chlebek <eric@sensu.io>
agent/agent.go Outdated Show resolved Hide resolved
Signed-off-by: Eric Chlebek <eric@sensu.io>
Copy link

@nikkictl nikkictl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing feedback and answering my questions! Also, excellent work on the liveness package and it's implementation 💯

Copy link
Contributor

@palourde palourde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested locally!

@echlebek echlebek merged commit 1dfd462 into master Jan 21, 2019
@echlebek echlebek deleted the keepalived/liveness branch January 24, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants