Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug where typemap gen broke on Go 1.12 #2965

Merged
merged 1 commit into from
May 17, 2019
Merged

Fix a bug where typemap gen broke on Go 1.12 #2965

merged 1 commit into from
May 17, 2019

Conversation

echlebek
Copy link
Contributor

The godoc command has been changed to go doc -all in the generator.

Signed-off-by: Eric Chlebek eric@sensu.io

@echlebek
Fix a bug where typemap gen broke on Go 1.12
46cc8ed 
Signed-off-by: Eric Chlebek <eric@sensu.io>
@echlebek echlebek assigned palourde and unassigned palourde May 15, 2019
@echlebek echlebek requested a review from palourde May 15, 2019 21:56
palourde
palourde approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@palourde palourde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@echlebek echlebek merged commit 9f1f64f into master May 17, 2019
@echlebek echlebek deleted the bugfix/typemap branch May 17, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palourde palourde palourde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@echlebek @palourde