Make etcd database size configurable #2968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Chlebek <eric@sensu.io>
echlebek
force-pushed
the
etcd-size-config
branch
from
8d73edb
to
09093e6
Compare
|
Does this PR close #2644? |
|
@Nikkiki indeed |
nikkictl
approved these changes
May 17, 2019
Signed-off-by: Eric Chlebek <eric@sensu.io>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
Etcd database size is now configurable, along with etcd maximum request size.
Why is this change necessary?
Some users may wish to tune these parameters when their workflows demand it.
Does your change need a Changelog entry?
Affirmative
Do you need clarification on anything?
Negative
Were there any complications while making this change?
Yes, not salient to the PR.
Have you reviewed and updated the documentation for this change? Is new documentation required?
Docs changes not required, these are advanced options and best exposed through the CLI help.
How did you verify this change?
I ran the backend with a maximum database size of 1024 bytes, and observed that it failed to start. Similar for max request size.