Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backward incompatibility change with SSL handling #1098

Closed
cjeanner opened this issue Mar 25, 2019 · 2 comments · Fixed by #1100
Closed

Backward incompatibility change with SSL handling #1098

cjeanner opened this issue Mar 25, 2019 · 2 comments · Fixed by #1100
Assignees
@treydock

Comments

@cjeanner
Copy link

Dear Sensu team,
One of the latest changes in the code base of this module apparently broke existing deploys in a specific case: when no puppet-server is involved.

In such a case, there isn't any puppet CA, thus the variable $facts['puppet_localcacert'] is set to Undef, and this "value" is refused by the String type.

Would it be possible to make some more checks on that value, and:

  • allow Undef (Variant[Undef, String] $ssl_ca_source - same goes for the other new ssl related variables)
  • ensure it's NOT undef when you include the ::sensu::ssl class

That would be really helpful!

Cheers,
C.
openstack-gerrit pushed a commit to openstack/openstack that referenced this issue Mar 25, 2019
@cjeanner @openstack-gerrit
Update git submodules
1f358a2 
* Update puppet-tripleo from branch 'master'
  - Pin puppet-sensu module
    
    Newest versions of puppet-sensu don't take into account the
    serverless usage we can have with puppet ("puppet apply" vs "puppet
    client"), making CI fail the unit tests for this module.
    
    An upstream bug has been open:
    sensu/sensu-puppet#1098
    
    The hash we're pinning is the same as in
    https://github.com/redhat-openstack/rdoinfo/blob/master/tags/stein-uc.yml#L880
    
    Change-Id: I1784a06052909b108c862ef76fc69e57bd778987
    Closes-Bug: #1821591
openstack-gerrit pushed a commit to openstack-archive/puppet-tripleo that referenced this issue Mar 25, 2019
@cjeanner
Pin puppet-sensu module
23a7b05 
Newest versions of puppet-sensu don't take into account the
serverless usage we can have with puppet ("puppet apply" vs "puppet
client"), making CI fail the unit tests for this module.

An upstream bug has been open:
sensu/sensu-puppet#1098

The hash we're pinning is the same as in
https://github.com/redhat-openstack/rdoinfo/blob/master/tags/stein-uc.yml#L880

Change-Id: I1784a06052909b108c862ef76fc69e57bd778987
Closes-Bug: #1821591
openstack-gerrit pushed a commit to openstack-archive/puppet-tripleo that referenced this issue Mar 25, 2019
@cjeanner @mwhahaha
Pin puppet-sensu module
368474f 
Newest versions of puppet-sensu don't take into account the
serverless usage we can have with puppet ("puppet apply" vs "puppet
client"), making CI fail the unit tests for this module.

An upstream bug has been open:
sensu/sensu-puppet#1098

The hash we're pinning is the same as in
https://github.com/redhat-openstack/rdoinfo/blob/master/tags/rocky.yml#L873

Change-Id: I1784a06052909b108c862ef76fc69e57bd778987
Closes-Bug: #1821591
openstack-gerrit pushed a commit to openstack-archive/puppet-tripleo that referenced this issue Mar 28, 2019
@cjeanner @mwhahaha
Pin puppet-sensu module
48dbeaf 
Newest versions of puppet-sensu don't take into account the
serverless usage we can have with puppet ("puppet apply" vs "puppet
client"), making CI fail the unit tests for this module.

An upstream bug has been open:
sensu/sensu-puppet#1098

The hash we're pinning is the same as in
https://github.com/redhat-openstack/rdoinfo/blob/master/tags/queens.yml#L869

Change-Id: I1784a06052909b108c862ef76fc69e57bd778987
Closes-Bug: #1821591
treydock added a commit that referenced this issue Mar 31, 2019
@treydock
Do not raise errors if custom puppet facts are undefined
2b28fdd 
use_ssl now requires ssl content parameters be defined
Fixes #1098
@treydock treydock mentioned this issue Mar 31, 2019
Merged
@treydock
Copy link
Collaborator

@cjeanner Give #1100 a try and let us know if that solves your problem. I made all the ssl source parameters optional which handles the Undef case. I also made is so an error will be raised if those parameters are undefined and SSL is still enabled.

@ghoneycutt
Copy link
Collaborator

Please re-open if you are still having an issue after using the changes that were just merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@treydock treydock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not raise errors if custom puppet facts are undefined sensu/sensu-puppet
3 participants
@ghoneycutt @treydock @cjeanner