Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint plugin #1177

Merged
merged 4 commits into from
Nov 24, 2019
Merged

Add lint plugin #1177

merged 4 commits into from
Nov 24, 2019

Conversation

ghoneycutt
Copy link
Collaborator

Description

Add a puppet-lint plugin to check for the presence of a newline character at the end of a file.

Motivation and Context

To ensure style compliance and lessen back and forth with pull requests.

@treydock
Copy link
Collaborator

That plugin just ensures \n is last character of manifest, it won't catch extra newlines where file ends with \n\n.

@treydock treydock added the bug label Nov 24, 2019
@ghoneycutt
Copy link
Collaborator Author

Right, though I saw we were not using it and should.

@ghoneycutt ghoneycutt merged commit 9457505 into sensu:master Nov 24, 2019
@ghoneycutt ghoneycutt deleted the add_lint_plugin branch November 24, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants