Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SensuAPIValidator timeout comments to 30 seconds #1315

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

robmcelhinney
Copy link
Contributor

@robmcelhinney robmcelhinney commented Nov 10, 2021

Match comments and REFERENCE file.

Pull Request Checklist

Comments in sensu_api_validator.rb and REFERENCE.md files say that the timeout is set to 15 but it's actually set to 30.
Set it to 15 to keep it consistent.

@ghoneycutt
Copy link
Collaborator

Would prefer to keep the default as is and instead update any documentation that is not aligned.

@robmcelhinney robmcelhinney changed the title Set SensuAPIValidator timeout to 15 seconds Set SensuAPIValidator timeout comments to 30 seconds Nov 11, 2021
@robmcelhinney
Copy link
Contributor Author

Would prefer to keep the default as is and instead update any documentation that is not aligned.

Ok, I changed the comments to 30 seconds then to keep it consistent.
I'll just use 15 on my config, I prefer keeping it shorter.

REFERENCE.md Outdated Show resolved Hide resolved
@ghoneycutt
Copy link
Collaborator

Thanks @robmcelhinney for finding and fixing this!

@ghoneycutt ghoneycutt merged commit 9cbb95c into sensu:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants