Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data source improvements #138

Merged
merged 28 commits into from Sep 21, 2020
Merged

Data source improvements #138

merged 28 commits into from Sep 21, 2020

Conversation

AleksMat
Copy link
Contributor

@AleksMat AleksMat commented Sep 7, 2020

Redefines data source object and enables users to define their own data sources. It also adds a new example notebook about data sources.

@AleksMat AleksMat mentioned this pull request Sep 7, 2020
Merged
batic
batic reviewed Sep 7, 2020
View reviewed changes
Copy link
Contributor

@batic batic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP, will continue with review tomorrow.

sentinelhub/data_sources.py Outdated Show resolved Hide resolved
sentinelhub/data_sources.py Outdated Show resolved Hide resolved
sentinelhub/data_sources.py Outdated Show resolved Hide resolved
sentinelhub/data_sources.py Outdated Show resolved Hide resolved
sentinelhub/data_sources.py Outdated Show resolved Hide resolved
sentinelhub/data_sources.py Outdated Show resolved Hide resolved
sentinelhub/data_sources.py Outdated Show resolved Hide resolved
sentinelhub/data_sources.py Outdated Show resolved Hide resolved
sentinelhub/data_sources.py Outdated Show resolved Hide resolved
batic
batic reviewed Sep 8, 2020
View reviewed changes
sentinelhub/data_sources.py Outdated Show resolved Hide resolved
sentinelhub/data_sources.py Outdated Show resolved Hide resolved
@AleksMat AleksMat mentioned this pull request Sep 15, 2020
Merged
batic
batic reviewed Sep 16, 2020
View reviewed changes
sentinelhub/data_request.py Outdated Show resolved Hide resolved
batic
batic reviewed Sep 16, 2020
View reviewed changes
sentinelhub/areas.py Outdated Show resolved Hide resolved
batic
batic reviewed Sep 17, 2020
View reviewed changes
sentinelhub/exceptions.py Outdated Show resolved Hide resolved
batic
batic reviewed Sep 17, 2020
View reviewed changes
tests/test_geopedia.py Outdated Show resolved Hide resolved
@batic
Copy link
Contributor

batic commented Sep 17, 2020

I only have one last comment regarding commented out test. After that, the PR can be merged. (I might suggest squashing the commit, though).

@AleksMat AleksMat merged commit 73a2d92 into develop Sep 21, 2020
@AleksMat AleksMat deleted the feat/data-source-abstraction branch October 19, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batic batic batic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AleksMat @batic