-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/batch #141
Feat/batch #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First part of review process - going through files on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally I'm ok with SHB, but I'd also like to see methods reordered groups of similar functionality methods (e.g. all properties together, all static methods together, everything dealing with creation of urls together etc.)
Codecov Report
@@ Coverage Diff @@
## develop #141 +/- ##
===========================================
- Coverage 90.88% 90.05% -0.84%
===========================================
Files 30 31 +1
Lines 3061 3257 +196
===========================================
+ Hits 2782 2933 +151
- Misses 279 324 +45
Continue to review full report at Codecov.
|
Moved get_json and get_xml functions to DownloadClient methods
Few more notes on the notebook with the example: a) With this, I conclude my long going review (really sorry about that). |
For now, I think it is ok to leave this as it is.
The problem here is only that I wouldn't want that |
Implements a Python interface for Sentinel Hub Batch Processing API. It also adds tests and a tutorial notebook.
Closes #136
Note: this PR also contains changes from PR #138, which should be merged first.