Issue #203: Refactor-Extensions-code-to-check-protocol-efficiently

Fixed IpmiExtension
sentrysoftware · Jun 3, 2024 · 31be857 · 31be857
1 parent 51aef13
commit 31be857
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 7 deletions.
diff --git a/...va/org/sentrysoftware/metricshub/engine/strategy/collect/ProtocolHealthCheckStrategy.java b/...va/org/sentrysoftware/metricshub/engine/strategy/collect/ProtocolHealthCheckStrategy.java
@@ -24,6 +24,7 @@
 import java.util.List;
 import lombok.Builder;
 import lombok.NonNull;
+
 import org.sentrysoftware.metricshub.engine.client.ClientsExecutor;
 import org.sentrysoftware.metricshub.engine.extension.ExtensionManager;
 import org.sentrysoftware.metricshub.engine.extension.IProtocolExtension;
@@ -42,7 +43,6 @@
  * responding or not.
  * </p>
  */
-
 public class ProtocolHealthCheckStrategy extends AbstractStrategy {
 
 	/**

diff --git a/...rg/sentrysoftware/metricshub/engine/strategy/collect/ProtocolHealthCheckStrategyTest.java b/...rg/sentrysoftware/metricshub/engine/strategy/collect/ProtocolHealthCheckStrategyTest.java
@@ -1,8 +1,6 @@
 package org.sentrysoftware.metricshub.engine.strategy.collect;
 
 import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
-import static org.mockito.ArgumentMatchers.any;
-import static org.mockito.Mockito.doNothing;
 import static org.mockito.Mockito.doReturn;
 import static org.sentrysoftware.metricshub.engine.common.helpers.KnownMonitorType.HOST;
 import static org.sentrysoftware.metricshub.engine.constants.Constants.HOSTNAME;
@@ -17,7 +15,6 @@
 import org.mockito.junit.jupiter.MockitoExtension;
 import org.sentrysoftware.metricshub.engine.client.ClientsExecutor;
 import org.sentrysoftware.metricshub.engine.configuration.HostConfiguration;
-import org.sentrysoftware.metricshub.engine.configuration.IConfiguration;
 import org.sentrysoftware.metricshub.engine.extension.ExtensionManager;
 import org.sentrysoftware.metricshub.engine.extension.IProtocolExtension;
 import org.sentrysoftware.metricshub.engine.extension.TestConfiguration;
@@ -83,8 +80,6 @@ void testCheckHealth() throws Exception {
 			.when(protocolExtensionMock)
 			.isValidConfiguration(telemetryManager.getHostConfiguration().getConfigurations().get(TestConfiguration.class));
 
-		//	doNothing().when(protocolExtensionMock).checkProtocol(telemetryManager.getHostname(), TelemetryManager.class));
-
 		// Create a new protocol health check strategy
 		final ProtocolHealthCheckStrategy healthCheckStrategy = new ProtocolHealthCheckStrategy(
 			telemetryManager,

diff --git a/...i-extension/src/main/java/org/sentrysoftware/metricshub/extension/ipmi/IpmiExtension.java b/...i-extension/src/main/java/org/sentrysoftware/metricshub/extension/ipmi/IpmiExtension.java
@@ -49,6 +49,9 @@
 @Slf4j
 public class IpmiExtension implements IProtocolExtension {
 
+	/**
+	 * The identifier for the WinRm protocol.
+	 */
 	private static final String IDENTIFIER = "ipmi";
 
 	private IpmiRequestExecutor ipmiRequestExecutor = new IpmiRequestExecutor();

diff --git a/...extension/src/test/java/org/sentrysoftware/metricshub/extension/wmi/WmiExtensionTest.java b/...extension/src/test/java/org/sentrysoftware/metricshub/extension/wmi/WmiExtensionTest.java
@@ -483,6 +483,6 @@ void testBuildConfiguration() throws InvalidConfigurationException {
 	void testGetIdentifier() {
 		String identifier = wmiExtension.getIdentifier();
 
-		assertEquals("wmi", identifier);   
+		assertEquals("wmi", identifier);
 	}
 }