-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Extensions code to check protocol efficiently #203
Labels
enhancement
New feature or request
Comments
SafaeAJ
added a commit
that referenced
this issue
Jun 3, 2024
SafaeAJ
added a commit
that referenced
this issue
Jun 3, 2024
Fixed IpmiExtension fixed ProtocolHealthCheckStrategy
SafaeAJ
added a commit
that referenced
this issue
Jun 4, 2024
Fixed comments in HttpExtension and WmiExtension
SafaeAJ
added a commit
that referenced
this issue
Jun 4, 2024
Modify OsCommandExtensionTest and WbemExtensionTest
SafaeAJ
added a commit
that referenced
this issue
Jun 4, 2024
Modify log info in checkProtocol method
SafaeAJ
added a commit
that referenced
this issue
Jun 4, 2024
Fixed style in ProtocolHealthCheckStrategy
SafaeAJ
added a commit
that referenced
this issue
Jun 4, 2024
NassimBtk
added a commit
that referenced
this issue
Jun 5, 2024
…r-extensions-code-to-check-protocol-efficiently Issue #203 : Refactor extensions code to check protocol efficiently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The OpenTelemetry-specific code is not passed to the protocol extension. Currently, the OpenTelemetry code observes the metric's value in the agent before sending it to the OTLP receiver.
The code you suggested is already implemented in the agent through the
ProtocolHealthCheckStrategy
, which is triggered at each collect cycle, except for themetricshub.host.protocol.up
collect.Indeed, the
ProtocolHealthCheckStrategy
can be updated to collect the protocol point, this will avoid code duplication in each extension. Several information are required from the TelemetryManager: hostname, configuration, so this can be passed as method arguments.This can be done in a separate issue as it is a refactoring task. Moreover, each extension needs to be updated ;). By the way good catch, thanks @bertysentry.
Originally posted by @NassimBtk in #201 (comment)
The text was updated successfully, but these errors were encountered: