Skip to content

Commit

Permalink
Issue #226: Bad timeout unit used by the ping extension
Browse files Browse the repository at this point in the history
* Updated comment in ExtensionProtocolsDeserializerTest.
  • Loading branch information
NassimBtk committed Jun 5, 2024
1 parent 2c21c66 commit 913d7d9
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ void testDeserialize() throws IOException {
assertEquals(Collections.emptyMap(), deserializer.deserialize(yamlParserMock, deserializeContext));
}

// Assert that the returned value is an empty map when the parser returns null for a configured protocol
// Assert that the returned value is a map containing the default configuration when the user doesn't configure
// the protocol's properties
// Example:
// protocols:
// ping:
Expand All @@ -70,7 +71,7 @@ void testDeserialize() throws IOException {
assertEquals(PingConfiguration.builder().build(), protocols.get("ping"));
}

// Assert normal deserialization
// Assert ordinary deserialization
{
final ObjectNode protocolsNode = JsonNodeFactory.instance.objectNode();
final ObjectNode pingNode = JsonNodeFactory.instance.objectNode();
Expand Down

0 comments on commit 913d7d9

Please sign in to comment.