Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ping extension uses an invalid timeout unit #226

Closed
NassimBtk opened this issue Jun 4, 2024 · 0 comments · Fixed by #227
Closed

Ping extension uses an invalid timeout unit #226

NassimBtk opened this issue Jun 4, 2024 · 0 comments · Fixed by #227
Assignees
@NassimBtk @CherfaElyes
Labels
bug Something isn't working

Comments

@NassimBtk
Copy link
Member

Problem

The InetAddress.isReachable method expects input in milliseconds, but the extension uses seconds for configuration. This discrepancy causes ICMP pings to fail due to an insufficient timeout value.
@NassimBtk NassimBtk self-assigned this Jun 4, 2024
@NassimBtk NassimBtk added the bug Something isn't working label Jun 4, 2024
NassimBtk added a commit that referenced this issue Jun 4, 2024
@NassimBtk
Issue #226: Bad timeout unit used by the ping extension
667bc24 
* Converted timeout value from seconds to milliseconds
NassimBtk added a commit that referenced this issue Jun 4, 2024
@NassimBtk
Issue #226: Bad timeout unit used by the ping extension
8e3ac61 
* Increased default timeout to 5 seconds.
@NassimBtk NassimBtk linked a pull request Jun 4, 2024 that will close this issue
Issue #226: Bad timeout unit used by the ping extension #227
Merged
NassimBtk added a commit that referenced this issue Jun 5, 2024
@NassimBtk
Issue #226: Bad timeout unit used by the ping extension
2136044 
* Supported default protocol configurations.
NassimBtk added a commit that referenced this issue Jun 5, 2024
@NassimBtk
Issue #226: Bad timeout unit used by the ping extension
2c21c66 
* Minor fixes in ExtensionProtocolsDeserializer.
NassimBtk added a commit that referenced this issue Jun 5, 2024
@NassimBtk
Issue #226: Bad timeout unit used by the ping extension
913d7d9 
* Updated comment in ExtensionProtocolsDeserializerTest.
NassimBtk added a commit that referenced this issue Jun 5, 2024
@NassimBtk
Merge pull request #227 from sentrysoftware/feature/issue-226-bad-tim…
cc5bc68 
…eout-unit-used-by-the-ping-extension

Issue #226: Bad timeout unit used by the ping extension
@iguitton iguitton changed the title Bad timeout unit used by the ping extension Ping extension uses an invalid timeout unit Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NassimBtk NassimBtk

@CherfaElyes CherfaElyes

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #226: Bad timeout unit used by the ping extension sentrysoftware/metricshub
2 participants
@NassimBtk @CherfaElyes