Issue #203: Refactor-Extensions-code-to-check-protocol-efficiently

Modify ProtocolHealthCheckStrategy
sentrysoftware · Jun 4, 2024 · ad04d4d · ad04d4d
1 parent 0681744
commit ad04d4d
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/...va/org/sentrysoftware/metricshub/engine/strategy/collect/ProtocolHealthCheckStrategy.java b/...va/org/sentrysoftware/metricshub/engine/strategy/collect/ProtocolHealthCheckStrategy.java
@@ -83,9 +83,8 @@ public void run() {
 		protocolExtensions.forEach(protocolExtension -> {
 			Optional<Boolean> protocolCheckResult = protocolExtension.checkProtocol(telemetryManager);
 
-			double metricValue;
 			if (!protocolCheckResult.isPresent()) {
-				metricValue = DOWN;
+				return;
 			} else {
 				metricValue = protocolCheckResult.get() ? UP : DOWN;
 			}
@@ -95,7 +94,7 @@ public void run() {
 				.collectNumberMetric(
 					telemetryManager.getEndpointHostMonitor(),
 					"metricshub.host.up{protocol=\"" + protocolExtension.getIdentifier() + "\"}",
-					metricValue,
+					protocolCheckResult.get() ? UP : DOWN,
 					telemetryManager.getStrategyTime()
 				);
 			// CHECKSTYLE:OFF