Develop HTTP Extension

[NassimBtk]

Description

Check List

Agent

• Remove the HttpProtocolConfig class.
• In ConfigHelper move the validateHttpInfo() method content to the HttpConfiguration class which is located in the metricshub-http-extension. And adapt the code in ConfigHelper so that we call IConfiguration#validateConfiguration (httpConfiguration) to validate the content of the Http configuration.
• Add the IConfiguration instance for http to the final Map<Class<? extends IConfiguration>, IConfiguration> protocolConfigurations map which is built in ConfigHelper#buildHostConfiguration.
• In the MetricsHub CLI, adapt the HttpConfigCli class.
• Re-write HttpConfigCli.toProtocol to call the extensionManager instance responsible of building the right IConfiguration for Http protocol.
• If it is required to build a new configuration for HTTP in the unit tests then create a HttpTestConfiguration class and create its extension HttpTestExtension.
• Remove ConfigHelperTest#testValidateHttpInfo() because the validation will be moved to the HttpConfiguration class in the metricshub-http-extension.
• Adapt the TaskSchedulingServiceTest to replace the removed classes by the extension classes E.g. HttpTestConfiguration.
• Adapt the HttpConfigCliTest tests. Probably Static Mocks will be involved.

Engine

• Remove the org.sentrysoftware:http dependency from metricshub-engine POM.
• Move ClientsExecutor.executeHttp code to the metricshub-http-extension. Make sure to remove the call from the ClientsExecutor.executeWql method and adapt the caller (SourceProcessor CriterionProcessor) to invoke the extensionManager correctly.
• Remove HttpConfiguration.class mapping from the HostConfiguration#CONFIGURATION_TO_SOURCES_MAP map.
• Move HttpConfiguration.java to metricshub-http-extension module.
• Move ProtocolHealthCheckStrategy#checkHttpHealth to HttpExtension located at the metricshub-http-extension module. Make sure to remove the unused constants and methods.
• Move the code of the method: CriterionProcessor#CriterionTestResult process(@SpanAttribute("criterion.definition") HttpCriterion HttpCriterion) to the appropriate class in the metricshub-http-extension module.
• Move the code of the method: SourceProcessor#process(@SpanAttribute("source.definition") final HttpSource httpSource)
• Move the HttpConfigurationTest class to the extension unit tests.
• Adapt correct engine unit tests because the code is moved to another module. #155

Extension

• Implement the IProtocolExtension class.
• Make sure to define the /metricshub-http-extension/src/main/resources/META-INF/services/org.sentrysoftware.metricshub.engine.extension.IProtocolExtension file so that the ServiceLoader loads the extension implementation correctly at runtime.
• Add the metricshub-engine,lombok, jupiter,jackson (all the necessary dependencies) in the extension project's POM.
• Make sure to create a jar using the maven-shade-plugin (POM) and set Multi-Release to true in the manifest entries of the jar.
• Make sure to include the required dependencies (org.sentrysoftware:http and org.sentrysoftware:metricshub-http-extension)
• Develop unit tests.

Packaging Windows and Linux

• Add the metricshub-http-extension as dependency.
• Update the maven-dependency-plugin, execution-id: unpack-extensions and add the artifactItem defining the metricshub-http-extension.