Issue #115: Develop HTTP Extension #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CherfaElyes
commented
Apr 9, 2024
CherfaElyes
commented
- Developed Http Extension and all its classes
- Refactored all the tests and made the necessary changes to make them work
- Tested the engine and the agent
- Added the missing javadoc to the engine and the HTTP Extension
* Developed Http Extension and all its classes * Refactored all the tests and made the necessary changes to make them work * Tested the engine and the agent
* Added the missing javadoc to the engine and the HTTP Extension * Fixed a bug on the HTTP extension
…evelop-http-extension
NassimBtk
reviewed
Apr 15, 2024
...http-extension/src/main/java/org/sentrysoftware/metricshub/extension/http/HttpExtension.java
Outdated
Show resolved
Hide resolved
NassimBtk
reviewed
Apr 15, 2024
...esources/META-INF/services/org.sentrysoftware.metricshub.engine.extension.IProtocolExtension
Outdated
Show resolved
Hide resolved
NassimBtk
requested changes
Apr 15, 2024
...ent/src/test/java/org/sentrysoftware/metricshub/agent/extension/HttpTestRequestExecutor.java
Outdated
Show resolved
Hide resolved
* Fixed some comments * Fixed some imports * Removed dead code
…evelop-http-extension
* Various adjustments and fixes * Refactored unit tests
NassimBtk
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.