Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source keys are incorrectly generated when the collect type is not defined in the Connector #131

Closed
NassimBtk opened this issue Mar 20, 2024 · 0 comments · Fixed by #132
Closed

Source keys are incorrectly generated when the collect type is not defined in the Connector #131

NassimBtk opened this issue Mar 20, 2024 · 0 comments · Fixed by #132
Assignees
@NassimBtk
Labels
bug Something isn't working

Comments

@NassimBtk
Copy link
Member

Problem

When a collect type (monoInstance or multiInstance) is not specified in a job within the connector, the custom JsonDeserializer improperly computes the node key during its traversal from the source node to the root node. This leads to an incorrect node keys for the source objects, such as ${source::monitors.system.collect.mapping.sources.source_1}, instead of the expected ${source::monitors.system.collect.sources.source_1}.
@NassimBtk NassimBtk added the bug Something isn't working label Mar 20, 2024
@NassimBtk NassimBtk self-assigned this Mar 20, 2024
NassimBtk added a commit that referenced this issue Mar 21, 2024
@NassimBtk
Issue #131: Fixed incorrect source keys when collect type is undefined
1ee35a6 
* Source keys are now generated at the pre processing phase.
* Added unit tests.
* Fixed failed unit tests.
* Removed keys retrieval method from the AbstractMapDeserializer class.
NassimBtk added a commit that referenced this issue Mar 21, 2024
@NassimBtk
Issue #131: Fixed incorrect source keys when collect type is undefined
ae886de 
* Source keys are now generated at the pre processing phase.
* Added unit tests.
* Fixed failed unit tests.
* Removed keys retrieval method from the AbstractMapDeserializer class.
NassimBtk added a commit that referenced this issue Mar 21, 2024
@NassimBtk
Issue #131: Fixed incorrect source keys when collect type is undefined
aa54121 
* Source keys are now generated at the pre processing phase.
* Added unit tests.
* Fixed failed unit tests.
* Removed keys retrieval method from the AbstractMapDeserializer class.
@NassimBtk NassimBtk linked a pull request Mar 21, 2024 that will close this issue
Issue #131: Fixed incorrect source keys when collect type is undefined #132
Merged
NassimBtk added a commit that referenced this issue Mar 21, 2024
@NassimBtk
Merge pull request #132 from sentrysoftware/feature/issue-131-source-…
1005d20 
…keys-are-incorrectly-generated-when-the-collect-type-is-not-defined-in-the-connector

Issue #131: Fixed incorrect source keys when collect type is undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NassimBtk NassimBtk

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #131: Fixed incorrect source keys when collect type is undefined sentrysoftware/metricshub
1 participant
@NassimBtk