Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #131: Fixed incorrect source keys when collect type is undefined #132

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Issue #131: Fixed incorrect source keys when collect type is undefined #132

merged 1 commit into from
Mar 21, 2024

Conversation

NassimBtk
Copy link
Member

  • Source keys are now generated at the pre processing phase.
  • Added unit tests.
  • Fixed failed unit tests.
  • Removed keys retrieval method from the AbstractMapDeserializer class.

@NassimBtk
Issue #131: Fixed incorrect source keys when collect type is undefined
aa54121 
* Source keys are now generated at the pre processing phase.
* Added unit tests.
* Fixed failed unit tests.
* Removed keys retrieval method from the AbstractMapDeserializer class.
@NassimBtk NassimBtk linked an issue Mar 21, 2024 that may be closed by this pull request
Source keys are incorrectly generated when the collect type is not defined in the Connector #131
Closed
CherfaElyes
CherfaElyes approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@CherfaElyes CherfaElyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the connectors are parsing and working fine 👍

TNohaic
TNohaic approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@TNohaic TNohaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine

@NassimBtk NassimBtk merged commit 1005d20 into main Mar 21, 2024
2 checks passed
@NassimBtk NassimBtk deleted the feature/issue-131-source-keys-are-incorrectly-generated-when-the-collect-type-is-not-defined-in-the-connector branch March 21, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MedMaalej MedMaalej MedMaalej approved these changes

@TNohaic TNohaic TNohaic approved these changes

@CherfaElyes CherfaElyes CherfaElyes approved these changes

@bertysentry bertysentry Awaiting requested review from bertysentry

@alexdgilbert alexdgilbert Awaiting requested review from alexdgilbert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source keys are incorrectly generated when the collect type is not defined in the Connector
4 participants
@NassimBtk @MedMaalej @TNohaic @CherfaElyes