Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hardware Module back to MetricsHub #172

Closed
9 tasks done
CherfaElyes opened this issue May 14, 2024 · 0 comments · Fixed by #180
Closed
9 tasks done

Add Hardware Module back to MetricsHub #172

CherfaElyes opened this issue May 14, 2024 · 0 comments · Fixed by #180
Assignees
@CherfaElyes
Labels
enhancement New feature or request java maven

Comments

@CherfaElyes
Copy link
Contributor

CherfaElyes commented May 14, 2024 •
edited
Loading

Given the relevance of the Hardware Module, it will be put back in MetricsHub.

Agent

  • Add Hardware module to the MetricsHub project
  • Add Hardware description in MetricsHub Readme.md
  • Add the Hardware dependency to the MetricsHub-agent pom.xml
  • Add HardwarePostDiscoveryStrategy on MonitoringTask where needed
  • Add HardwarePostDiscoveryStrategy on MetricsHubCliService where needed
  • Refactor MonitoringTaskTest class to include HardwareStrategy running Mock
  • Refactor all the tests to make them run correctly
  • Plug Hardware module into MetricsHub parent
  • Put back the Hardware documentation (maybe in another issue)
@CherfaElyes CherfaElyes self-assigned this May 14, 2024
@CherfaElyes CherfaElyes added enhancement New feature or request java maven labels May 14, 2024
CherfaElyes added a commit that referenced this issue May 17, 2024
@CherfaElyes
Issue #172: Add Hardware Module back to MetricsHub
dffa84c 
* Plugged back MetricsHub-Hardware into the MetricsHub project
* Plugged the hardware strategies into the metricshub agent
CherfaElyes added a commit that referenced this issue May 17, 2024
@CherfaElyes
Issue #172: Add Hardware Module back to MetricsHub
c849e16 
* Added back metricshub-hardware to MetricsHub
* Plugged back metricshub-hardware into the CLI and the Agent
* Refactored the code and the tests to make them work
* Tested using the MetricsHub CLI and the Agent
@CherfaElyes CherfaElyes linked a pull request May 17, 2024 that will close this issue
Issue #172: Add Hardware Module back to MetricsHub #180
Merged
CherfaElyes added a commit that referenced this issue May 17, 2024
@CherfaElyes
Issue #172: Add Hardware Module back to MetricsHub
5b71492 
* Reformatted the code
CherfaElyes added a commit that referenced this issue May 17, 2024
@CherfaElyes
Issue #172: Add Hardware Module back to MetricsHub
5dea901 
* Removed jacoco exclusion
NassimBtk added a commit that referenced this issue May 17, 2024
@NassimBtk
Issue #172: Add Hardware Module back to MetricsHub
e5cb267 
* Updated IT tests to call the Hardware strategies.
* Updated expected.json files from both DellOpenManageIT and
SuperConnectorOsIT.
NassimBtk added a commit that referenced this issue May 17, 2024
@NassimBtk
Merge pull request #180 from sentrysoftware/feature/issue-172-add-har…
8d39dec 
…dware-module-back-to-metricshub

Issue #172: Added Hardware Module back to MetricsHub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CherfaElyes CherfaElyes

Labels
enhancement New feature or request java maven
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #172: Add Hardware Module back to MetricsHub sentrysoftware/metricshub
1 participant
@CherfaElyes