Issue #172: Add Hardware Module back to MetricsHub #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CherfaElyes
commented
May 17, 2024
CherfaElyes
commented
- Added back metricshub-hardware to MetricsHub
- Plugged back metricshub-hardware into the CLI and the Agent
- Refactored the code and the tests to make them work
- Tested using the MetricsHub CLI and the Agent
* Plugged back MetricsHub-Hardware into the MetricsHub project * Plugged the hardware strategies into the metricshub agent
…dd-hardware-module-back-to-metricshub
* Added back metricshub-hardware to MetricsHub * Plugged back metricshub-hardware into the CLI and the Agent * Refactored the code and the tests to make them work * Tested using the MetricsHub CLI and the Agent
…dd-hardware-module-back-to-metricshub
9 tasks
* Reformatted the code
* Removed jacoco exclusion
* Updated IT tests to call the Hardware strategies. * Updated expected.json files from both DellOpenManageIT and SuperConnectorOsIT.
NassimBtk
approved these changes
May 17, 2024
NassimBtk
approved these changes
May 17, 2024
NassimBtk
deleted the
feature/issue-172-add-hardware-module-back-to-metricshub
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.