Add functions MD5 SHA1 SHA1HMAC SHA256 SHA256HMAC #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't you factor those functions already? But don't create DIGEST with an instance of Digest, instead pass it a class and in 'apply' create a new instance, otherwise you would be sharing the same Digest instance between all current executions of the DIGEST functions. so DIGEST(String name, Class<? extends GeneralDigest>) |
hbs
reviewed
Nov 14, 2016
|
|
||
| return stack; | ||
| } catch (Exception exp) { | ||
| throw new WarpScriptException("Unable to instantiate digest " + getName()); |
There was a problem hiding this comment.
Can you change the WarpScriptException to start with getName() so as to retain the overall structure.
throw new WarpScriptException(getName() + " unable to instantiate digest").
Same for HMAC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds cryptographic hashes and hashmac.
The code of MD5 SHA1 & SHA256 is not factorized.
It could be with a generic function DIGEST with the Digest instance given in the constructor.
by ex : functions.put("SHA1", new DIGEST("SHA1", new SHA1Digest()));