Make median aggregator always return a double. #653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: Median aggregator must always return a double to avoid confusion.
A wildly accepted definition of the median, as on NIST, makes it so the median of an even number of elements is the mean of two elements. This means the median has a probability of 1 of being a floating point number for a list of floating point number and a probability of 0.25 of being a floating point number for a list of integers (0.5 the list has an odd number of elements, 0.25 the list has an even number of elements and the difference between the two elements use to compute the mean is even and 0.25 the list has an even number of elements and the difference between the two elements use to compute the mean is odd). The simplest solution is thus to always return a double.
This PR also fixes this bug/unexpected behavior: