Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value to $1 to avoid unbound variable error if no parameter #905

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

ftence
Copy link
Contributor

@ftence ftence commented Jan 20, 2021

Fixes #874

set -u does not seems to pose any problem, but I only tested on Ubuntu 20.04.

# Extract JAVA_OPTS before we switch to strict mode
JAVA_OPTS=${JAVA_OPTS:-}

Seems to indicate set -u could pose problem with default values.

@hbs hbs merged commit 21f3b66 into senx:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear error message when warp10-standalone.sh is used without parameter
3 participants